Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed BackgroundWorkers to async await #728

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Changed BackgroundWorkers to async await #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
31fd5cd
Changed BackgroundWorkers in Project to async await
tombogle Oct 2, 2020
80f9fa1
Merge branch 'master' into replace-backgroundworker-with-async-await
tombogle Oct 2, 2020
d6a37f5
Added try-catch so that errors during parse would not be ignored.
tombogle Oct 6, 2020
839fe13
[WIP]
tombogle Oct 6, 2020
cb54a4b
Merge branch 'master' into replace-backgroundworker-with-async-await
tombogle Dec 1, 2020
8276991
Merge branch 'master' into replace-backgroundworker-with-async-await
tombogle Dec 7, 2020
6d8389c
Merge branch 'master' into replace-backgroundworker-with-async-await
tombogle Dec 11, 2020
e17bc4a
Merge branch 'master' into replace-backgroundworker-with-async-await
tombogle Dec 16, 2020
d2c0fc0
Merge branch 'master' into replace-backgroundworker-with-async-await
tombogle Jul 26, 2021
db756e2
Merge branch 'master' into replace-backgroundworker-with-async-await
tombogle Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 15 additions & 20 deletions Glyssen/Dialogs/GenerateGroupsProgressDialog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
using System;
using System.ComponentModel;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using System.Windows.Forms;
using GlyssenEngine;
using GlyssenEngine.Bundle;
Expand All @@ -13,10 +15,12 @@ namespace Glyssen.Dialogs
{
class GenerateGroupsProgressDialog : ProgressDialogWithAcknowledgement
{
private readonly CharacterGroupGenerator m_generator;
private readonly string m_sizeInfo;

public GenerateGroupsProgressDialog(Project project, DoWorkEventHandler doWorkEventHandler, bool firstRun, bool replaceCancelButtonWithLink = false)
public GenerateGroupsProgressDialog(Project project, CharacterGroupGenerator generator, bool firstRun, bool replaceCancelButtonWithLink = false)
{
m_generator = generator;
InitializeComponent();

Text = LocalizationManager.GetString("DialogBoxes.GenerateGroupsProgressDialog.Title", "Generating Groups");
Expand Down Expand Up @@ -60,27 +64,25 @@ public GenerateGroupsProgressDialog(Project project, DoWorkEventHandler doWorkEv
ProgressLabelTextWhenComplete = LocalizationManager.GetString("DialogBoxes.GenerateGroupsProgressDialog.Complete",
"Group generation is complete.");
BarStyle = ProgressBarStyle.Marquee;
BackgroundWorker worker = new BackgroundWorker();
worker.WorkerSupportsCancellation = true;
worker.DoWork += doWorkEventHandler;
BackgroundWorker = worker;
}

protected override void OnBackgroundWorker_RunWorkerCompleted(object sender, RunWorkerCompletedEventArgs e)
protected override void DoWork(CancellationToken cancellationToken)
{
if (e.Error != null)
try
{
m_generator.GenerateCharacterGroups(cancellationToken);
}
catch
{
if (!CanCancel)
throw e.Error;
throw;
var msg = LocalizationManager.GetString("DialogBoxes.GenerateGroupsProgressDialog.GenerationFailed",
"New character groups could not be generated to satisfy the project settings for the current cast size. ({0})",
"Parameter is a statement about the number of voice actors or planned cast size.");
MessageBox.Show(this, String.Format(msg, m_sizeInfo), Text, MessageBoxButtons.OK, MessageBoxIcon.Exclamation);
DialogResult = DialogResult.Cancel;
Close();
}
else
base.OnBackgroundWorker_RunWorkerCompleted(sender, e);
}

private void InitializeComponent()
Expand All @@ -100,11 +102,10 @@ public static void GenerateGroupsWithProgress(Project project, bool attemptToPre
if (forceMatchToActors)
project.CharacterGroupGenerationPreferences.CastSizeOption = CastSizeOption.MatchVoiceActorList;
bool saveGroups = false;
using (var progressDialog = new GenerateGroupsProgressDialog(project, OnGenerateGroupsWorkerDoWork, firstGroupGenerationRun, cancelLink))
{
var generator = new CharacterGroupGenerator(project, ghostCastSize, progressDialog.BackgroundWorker);
progressDialog.ProgressState.Arguments = generator;

var generator = new CharacterGroupGenerator(project, ghostCastSize);
using (var progressDialog = new GenerateGroupsProgressDialog(project, generator, firstGroupGenerationRun, cancelLink))
{
if (progressDialog.ShowDialog() == DialogResult.OK && generator.GeneratedGroups != null)
{
var assignedBefore = project.CharacterGroupList.CountVoiceActorsAssigned();
Expand All @@ -124,11 +125,5 @@ public static void GenerateGroupsWithProgress(Project project, bool attemptToPre
}
project.Save(saveGroups);
}

private static void OnGenerateGroupsWorkerDoWork(object s, DoWorkEventArgs e)
{
var generator = (CharacterGroupGenerator)((ProgressState)e.Argument).Arguments;
generator.GenerateCharacterGroups();
}
}
}
Loading