-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LT-21963: Copy Malay to an alternate writing system code (ms -> zlm) #237
base: release/9.1
Are you sure you want to change the base?
Conversation
<ItemGroup> | ||
<PackageReference Include="NUnit" Version="3.13.3" PrivateAssets="All" /> | ||
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would double check this version of the adapter works (it might silently fail and not run any tests), I believe only 4.3.2
supports this version of NUnit but I may be thinking of the dotnet version in which case I'm not sure if version 4.3.2
is only required for net461
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it did work, adding this allowed John to run the tests in visual studio without Resharper. I bumped this up to 462 since it was missed in the earlier round of updates. It looks like NUnit3TestAdapter at this version supports 462.
<ItemGroup> | ||
<PackageReference Include="NUnit" Version="3.13.3" PrivateAssets="All" /> | ||
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it did work, adding this allowed John to run the tests in visual studio without Resharper. I bumped this up to 462 since it was missed in the earlier round of updates. It looks like NUnit3TestAdapter at this version supports 462.
This change is