-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jest testing / readme update #45
base: master
Are you sure you want to change the base?
Conversation
Added jest for testing our code And updated the readme with a lot more usefull information.
Readme changes looks good ( maybe add notes about docker as an option as well )
So this just calls jest, but we don't have any tests yet, right? Do you have anything in mind to put as first test?
I don't mind moving it to org. Name suggestions? |
my initial thought was javascript-vim-debugger to make it easily searchable through google. will try to add docker notes. i am not that familiar with docker yet. that kind of makes it a little bit tricky. for testing I also need to setup cycle ci or travis ci for the project to make sure pr can only be merged if our tests don't fail |
hm not exactly sure why the markdown table is broken. |
what are you using for preview? |
i am not sure that this is the best place to maintain the list of all the things that we want to to. github issue are somewhat good but its rly great if you have a file with all the things that you want to do when offline
If you don't want to configure nvm to work with the debugger or your affraid you could break your current setup, | ||
just download the binary to your desktop. | ||
```bash | ||
~/Desktop/node-v7.6.0-darwin-x64/bin/node --debug-brk examples/qqq.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--debug-brk and --debug are deprecated might want to refactor
~/Desktop/node-v7.6.0-darwin-x64/bin/node --debug-brk examples/qqq.js | |
~/Desktop/node-v7.6.0-darwin-x64/bin/node --inspect-brk examples/qqq.js |
This alias works assuming you put the node file you downloaded from [npm][npm] onto your desktop | ||
If you want to place it somewhere else update the path accordingly | ||
```bash | ||
alias node7.6="~/Desktopnode-v7.6.0-darwin-x64/bin/node --debug-brk" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alias node7.6="~/Desktopnode-v7.6.0-darwin-x64/bin/node --debug-brk" | |
alias node7.6="~/Desktopnode-v7.6.0-darwin-x64/bin/node --inspect-brk" |
Is this still coming into the project? I'd be super excited to see this project active again! |
Hey @CADBOT I'm really struggling to find time for my open source projects lately, I'd like to give a bit more attention to this but unfortunately can't promise anything |
@sidorares I'm pretty passionate about having this work again. I'd love to help however I can! Would you be interested in help maintaining the project? |
definitely! How much you already know about structure of this project? Old v8 debugger protocol, chrome remote debugging protocol, vim-netbeans etc? Happy to answer any questions |
Not a whole lot, but I'm very willing to learn! I'll dig through the code a bit and reach out to you in the next few weeks via the email on your github after I get situated. Is there a better way to reach you? |
email is ok but if you feel discussion can benefit others it's better to do it in the open in GH issues ( if you want to discuss any private matter of security issue of course please email) |
Added jest for testing our code
And updated the readme with a lot more usefull information.
the things that i am currently thinking about that could help.
============
would you be ok if we switch things over from gitter to slack ? have every little experience with gitter while slack i use on a daily basis.so i could make sure that i keep up with people that do have questions.
Also i was wondering what do you think about taking the project and making and organisation for it.
I also work on the debugger for firefox. There we have an organisation and that works pretty great.
https://github.com/devtools-html/debugger.html
Once we have the organisation in place i would apply to make an open collective for this project.
As the main issue always tend to be how to find the proper time to work on those great side projects.