Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest testing / readme update #45

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Anzumana
Copy link

@Anzumana Anzumana commented Jan 11, 2018

Added jest for testing our code
And updated the readme with a lot more usefull information.

the things that i am currently thinking about that could help.

============
would you be ok if we switch things over from gitter to slack ? have every little experience with gitter while slack i use on a daily basis.so i could make sure that i keep up with people that do have questions.

Also i was wondering what do you think about taking the project and making and organisation for it.
I also work on the debugger for firefox. There we have an organisation and that works pretty great.
https://github.com/devtools-html/debugger.html

Once we have the organisation in place i would apply to make an open collective for this project.
As the main issue always tend to be how to find the proper time to work on those great side projects.

Added jest for testing our code
And updated the readme with a lot more usefull information.
@sidorares
Copy link
Owner

sidorares commented Jan 12, 2018

Readme changes looks good ( maybe add notes about docker as an option as well )

Added jest for testing our code

So this just calls jest, but we don't have any tests yet, right? Do you have anything in mind to put as first test?

Also i was wondering what do you think about taking the project and making and organisation for it.

I don't mind moving it to org. Name suggestions? node-vim-debugger as org name? (maybe node is bad name as by moving to CDP we'll get browser client side scripts debugging from vim was well. js-vim-debugger ?)

@Anzumana
Copy link
Author

my initial thought was javascript-vim-debugger to make it easily searchable through google.
The more traction we can generate the better.
but js-vim-debugger would work for me too.
i rly like the shorthand jvd for the project to be honest :) But thats the case with both names ^^

will try to add docker notes. i am not that familiar with docker yet. that kind of makes it a little bit tricky.

for testing
the best place would probably be ensuring that the version for 7.6 is still viable with any future changes. So those would be the tests that i would like to create first.

I also need to setup cycle ci or travis ci for the project to make sure pr can only be merged if our tests don't fail

@Anzumana
Copy link
Author

hm not exactly sure why the markdown table is broken.
in my markdown preview everything seems fine.ˆˆ
will have to look into that tomorrow

@sidorares
Copy link
Owner

what are you using for preview?

@Anzumana
Copy link
Author

http://marked2app.com/ by @ttscoff

i am not sure that this is the best place to maintain the list of
all the things that we want to to.
github issue are somewhat good but its rly great if you have a file with
all the things that you want to do when offline
If you don't want to configure nvm to work with the debugger or your affraid you could break your current setup,
just download the binary to your desktop.
```bash
~/Desktop/node-v7.6.0-darwin-x64/bin/node --debug-brk examples/qqq.js
Copy link

@si-mikey si-mikey Mar 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--debug-brk and --debug are deprecated might want to refactor

Suggested change
~/Desktop/node-v7.6.0-darwin-x64/bin/node --debug-brk examples/qqq.js
~/Desktop/node-v7.6.0-darwin-x64/bin/node --inspect-brk examples/qqq.js

This alias works assuming you put the node file you downloaded from [npm][npm] onto your desktop
If you want to place it somewhere else update the path accordingly
```bash
alias node7.6="~/Desktopnode-v7.6.0-darwin-x64/bin/node --debug-brk"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alias node7.6="~/Desktopnode-v7.6.0-darwin-x64/bin/node --debug-brk"
alias node7.6="~/Desktopnode-v7.6.0-darwin-x64/bin/node --inspect-brk"

@CADBOT
Copy link

CADBOT commented Aug 23, 2019

Is this still coming into the project? I'd be super excited to see this project active again!

@sidorares
Copy link
Owner

Hey @CADBOT I'm really struggling to find time for my open source projects lately, I'd like to give a bit more attention to this but unfortunately can't promise anything

@CADBOT
Copy link

CADBOT commented Aug 27, 2019

@sidorares I'm pretty passionate about having this work again. I'd love to help however I can! Would you be interested in help maintaining the project?

@sidorares
Copy link
Owner

Would you be interested in help maintaining the project?

definitely! How much you already know about structure of this project? Old v8 debugger protocol, chrome remote debugging protocol, vim-netbeans etc? Happy to answer any questions

@CADBOT
Copy link

CADBOT commented Sep 4, 2019

Not a whole lot, but I'm very willing to learn! I'll dig through the code a bit and reach out to you in the next few weeks via the email on your github after I get situated. Is there a better way to reach you?

@sidorares
Copy link
Owner

Is there a better way to reach you?

email is ok but if you feel discussion can benefit others it's better to do it in the open in GH issues ( if you want to discuss any private matter of security issue of course please email)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants