Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for invalid bridge/bond configuration #9534

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jnohlgard
Copy link

Pull Request

What? (description)

Improve the details in the error message shown when the machine config contains an interface that has more than one 'master' link.

Why? (reasoning)

I was experimenting with some changes in the config code and I saw these messages because of mistakes in my code, but the messages contained too little detail to allow me to pinpoint what to fix without using the debugger to look at the variables.

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)

See make help for a description of the available targets.

Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposed
Development

Successfully merging this pull request may close these issues.

2 participants