feat: run embedded discovery service in Omni

[utkuozdemir]

Run a discovery service instance inside Omni (enabled by default).

It listens only on the SideroLink interface on port 8093.

Clusters can opt in to use this embedded discovery service instead of the discovery.talos.dev. It is added as a new cluster feature both on frontend and in cluster templates.

Closes #20.

Docs: siderolabs/omni-docs#83

[utkuozdemir]

This is the culprit, otherwise PROTOBUF_GO_VERSION 1.34.1 is fine.

[TimJones]

Just to note: make sure we also update omin-docs to reflect the new feature option in cluster templates.

[utkuozdemir]

Just to note: make sure we also update omin-docs to reflect the new feature option in cluster templates.

Thanks for the reminder, sure will do.

[smira]

I think (after the discussion in the meeting) we need to default this feature to 'disabled' (i.e. use discovery.talos.dev by default).

[utkuozdemir]

I think (after the discussion in the meeting) we need to default this feature to 'disabled' (i.e. use discovery.talos.dev by default).

Changed the implementation to be that way, greatly simplified.

[Unix4ever]

I guess ClusterMachineTeardown controller should check the cluster features and pick the right discovery service instance depending on which one is enabled for the cluster.

[utkuozdemir]

I guess ClusterMachineTeardown controller should check the cluster features and pick the right discovery service instance depending on which one is enabled for the cluster.

Oh that's a good point, we need 2 discovery clients living in the same time in fact. I'll fix that.

[utkuozdemir]

I guess ClusterMachineTeardown controller should check the cluster features and pick the right discovery service instance depending on which one is enabled for the cluster.

Done. The logic there was not working properly anyway - was probing an already deleted ClusterMachineIdentity and returning without actually calling AffiliateDelete. I fixed the logic there and tested both with and without embedded discovery service being enabled.

Also addressed all other comments.

[utkuozdemir]

/m