Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Hiero API deprecated projectRoot methods #73

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dealmeida
Copy link

@dealmeida dealmeida commented Sep 23, 2020

In Nuke 12, some methods of the API hiero.core are deprecated and will be removed. That's the case for Project.projectRoot() and Project.setProjectRoot()

This Pull Request proposes to handle these cases with wrapper methods that will call the API method recommended by Hiero
Documentation when the Nuke Major Version being used is superior or equal to 12.

https://learn.foundry.com/hiero/developers/12.0/hieropythondevguide/api/api_core.html

@aoblet
Copy link

aoblet commented Nov 3, 2020

@pscadding, @jfboismenu what do you think ?

@jfboismenu
Copy link
Contributor

Hi!
Does this mean that our Hiero integration is currently broken with Nuke 12? I find the wording from Foundry confusing. The methods are listed as part of the API but being removed?

@dealmeida
Copy link
Author

dealmeida commented Nov 5, 2020

Hello,

In 12.1 - the only minor version we've tested until now - the integration is not broken: there's this warning printed on terminal ([DEPRECATION WARNING] Project.setProjectRoot() will be removed in Nuke 12...) but the methods still work. We haven't tested the 12.2 version.

@dealmeida
Copy link
Author

Hi,
I've just tested the same methods - projectRoot() and setProjectRoot() - with nuke 12.2v1 and they both work in spite of the warning messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants