Fix seth/rebar_lock_deps_plugin/issues/16. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider a directory layout like this:
apps/lexer/rebar.config
parser/rebar.config
codegen/rebar.config
deps/*/rebar.config
rel/
rebar.config
The top-level `rebar.config` specifies `{sub_dirs, ["rel", "apps/*"]},
and each `rebar.config` has its own set of `deps`.
`rebar_lock_deps_plugin` does not lock the dependencies specified in the
`apps/{lexer,parser,codegen}/rebar.config` files. This is a major issue
for certain projects of mine.
This difficulty arises because `rebar_lock_deps_plugin` apparently does
not scan `sub_dir` directories for dependencies. Since `rebar` itself
_does_ scan `sub_dir` directories for dependencies, it seems reasonable
to expect that `rebar_lock_deps_plugin` would do it, too.
| {filename:basename(D), dep_names(extract_deps(D))} | ||
| || D <- DepDirs ]. | ||
| Acc ++ [{filename:basename(D), dep_names(extract_deps(D))} | ||
| || D <- DepDirs]. |
There was a problem hiding this comment.
indent looks off here? maybe a hard tab?
|
Hiya. Thanks for this PR. Would you be willing to add a small test case that could be used to verify the behavior? I know the current test coverage isn't great, but no time like the present to improve that :) A few minor comments and since I merged your other fix this now needs a rebase. But I like the idea of teaching the plugin how to handle nested projects as you have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a directory layout like this:
The top-level
rebar.configspecifies{sub_dirs, ["rel", "apps/*"]},and each
rebar.confighas its own set ofdeps.rebar_lock_deps_plugindoes not lock the dependencies specified in theapps/{lexer,parser,codegen}/rebar.configfiles. This is a major issuefor certain projects of mine.
This difficulty arises because
rebar_lock_deps_pluginapparently doesnot scan
sub_dirdirectories for dependencies. Sincerebaritselfdoes scan
sub_dirdirectories for dependencies, it seems reasonableto expect that
rebar_lock_deps_pluginwould do it, too.