Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make crate no_std compatible #389

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

olanod
Copy link

@olanod olanod commented May 31, 2024

Make crate no_std while keeping it backwards compatible with a default std feature enabled(only used to impl Error for ParseError).

@Chiichen Chiichen mentioned this pull request Jun 4, 2024
@LastLeaf
Copy link

LastLeaf commented Jun 7, 2024

It seems that the changes are not complete. I still find some deps need changes or default-features = false .

@olanod
Copy link
Author

olanod commented Jun 7, 2024

I tested it with cargo build --no-default-features and cargo test with default features on purpose to use std. Is that what you tried?

@LastLeaf
Copy link

LastLeaf commented Jun 7, 2024

I tested it with cargo build --no-default-features and cargo test with default features on purpose to use std. Is that what you tried?

I built with --target armv7a-none-eabi (which does not have a std) and fixed some of the compilation errors. You can take a look at my branch. It also requires a dep change.

@olanod
Copy link
Author

olanod commented Jun 10, 2024

Merged your branch as your PR for the dependency was merged and released.

@LastLeaf
Copy link

More changes are needed in the cssparser-color crate. My branch has been updated.

Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, but can you rebase and add the license headers? Thanks

src/math.rs Show resolved Hide resolved
src/math.rs Show resolved Hide resolved
@emilio emilio changed the title Make create no_std compatible Make crate no_std compatible Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants