-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make crate no_std compatible #389
base: main
Are you sure you want to change the base?
Conversation
It seems that the changes are not complete. I still find some deps need changes or |
I tested it with |
I built with |
Merged your branch as your PR for the dependency was merged and released. |
More changes are needed in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, but can you rebase and add the license headers? Thanks
b96cd47
to
0d98d46
Compare
Make crate no_std while keeping it backwards compatible with a default
std
feature enabled(only used to impl Error for ParseError).