SubpixelAA FreeType rasterize_glyph fix #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this changes a public method, it requires a major version update. Could we exclude this change from this PR since it's not a critical part of the fix? |
jdm
approved these changes
Oct 12, 2024
This reverts commit a8231d7.
|
Absolutely, I missed that it's a public facing api. The change has been reverted 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
rasterize_glyphfor SubpixelAA in FreeType and adds a new test covering this case.Fixes issue #252.
There is a also a small type change to
bytes_per_pixelto avoid casts to usize.