New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype pollution in metadata setter #521

Open

aplhk wants to merge 1 commit into serversideup:master from aplhk:master

aplhk commented Nov 13, 2022

Hi there, I found a potential prototype pollution in the metadata setter setSongMetaData and setPlaylistMetaData under some specific condition.

Here is the sample code:

let obj = {};
Amplitude.addPlaylist("__proto__", {}, []);
Amplitude.setPlaylistMetaData("__proto__", { a: "pollution" });
console.log(obj.a); // output: pollution

Expected behaviour: obj.a should be undefined.


          Add hasOwnProperty checks to metadata setters

87ed920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet