Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.1 #563

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Version 4.1 #563

merged 6 commits into from
Oct 15, 2024

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

fix #498
fix #522
fix #523
fix #524

What does this implement/fix? Explain your changes.

Version 4.1

Any other comments?

@sepandhaghighi sepandhaghighi added this to the PYCM 4.1 milestone Oct 15, 2024
@sepandhaghighi sepandhaghighi self-assigned this Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (f1ecd45) to head (36bbf97).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #563   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          14       14           
  Lines        3139     3139           
  Branches      433      433           
=======================================
  Hits         3129     3129           
  Misses          4        4           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes.

Comment on lines -64 to +72
"outputs": [],
"outputs": [
{
"name": "stderr",
"output_type": "stream",
"text": [
"Keyring is skipped due to an exception: invalid syntax (core.py, line 48)\n"
]
}
],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems an extra change, we can revert it.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not related to the PyCM code. I think this warning is associated with the pip version.

Document/Example2.ipynb Show resolved Hide resolved
Document/Example7.ipynb Show resolved Hide resolved
Document/Example8.ipynb Show resolved Hide resolved
README.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add DO as one of the project's supporters.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 36bbf97

@sadrasabouri sadrasabouri merged commit 7caa612 into dev Oct 15, 2024
51 checks passed
@sadrasabouri sadrasabouri deleted the release branch October 15, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants