Updated the 'data/data-representation' session to be in line with the OpenEdu methodology. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adelin Popa <[email protected]>
AdoX13
added
area/reading
teodutu
requested changes
Jul 8, 2024
There was a problem hiding this comment.
The content overall is good. Fix the issues I pointed out and the failing CI/CD tests as well: https://github.com/security-summer-school/essentials-security/pull/13/checks
There was a problem hiding this comment.
Convert this file to linux line endings.
Comment on lines
+3
to
+4
| My friend Tommy is really passionate about art. Lately, he got into something called ASCII art and e-mailed me the following attachment. | ||
| I am too afraid to tell him that I don't know how to open it. Can you help? |
There was a problem hiding this comment.
Suggested change
| My friend Tommy is really passionate about art. Lately, he got into something called ASCII art and e-mailed me the following attachment. | |
| I am too afraid to tell him that I don't know how to open it. Can you help? | |
| My friend Tommy is really passionate about art. | |
| Lately, he got into something called ASCII art and e-mailed me the following attachment. | |
| I am too afraid to tell him that I don't know how to open it. | |
| Can you help? |
Use one sentence per line.
Comment on lines
+3
to
+4
| Thanos had 6 Infinity Stones, but I have something better: 6 Infinity Hashes, that store the truth of the whole universe. | ||
| Wrap it with `SSS{}` and `_` instead of space, and spread it with everyone! |
There was a problem hiding this comment.
Suggested change
| Thanos had 6 Infinity Stones, but I have something better: 6 Infinity Hashes, that store the truth of the whole universe. | |
| Wrap it with `SSS{}` and `_` instead of space, and spread it with everyone! | |
| Thanos had 6 Infinity Stones, but I have something better: 6 Infinity Hashes, that store the truth of the whole universe. | |
| Wrap it with `SSS{}`, use `_` instead of space, and spread it with everyone! |
There was a problem hiding this comment.
Honestly there was no need for this image to be .svg, since it's a meme, not a constructed image, but it's fine
| +------------------------------------> 1. File Type | ||
| ``` | ||
|
|
||
|  |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite Checklist
Description of changes