Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURESIN-1464] | Adding Custom Key and Config Support for CTlog #90

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tommyd450
Copy link
Contributor

@tommyd450 tommyd450 commented Nov 4, 2024

As it stands Keys can be added as a variable in roles/tas_single_node/defaults/main.yml.
Custom Config will follow soon but will need to add custom treeId specifications.

When testing ensure the keys and or config you provide are inputed like the following:

tas_single_node_custom_ctlog_private_key: |
    <Key Here>

@tommyd450 tommyd450 requested a review from a team as a code owner November 4, 2024 11:34
@tommyd450 tommyd450 requested a review from SequeI November 6, 2024 10:58
@tommyd450 tommyd450 changed the title [WIP] [SECURESIN-1464] | Adding Custom Key and Config Support for CTlog [SECURESIN-1464] | Adding Custom Key and Config Support for CTlog Nov 6, 2024
Copy link
Contributor

@SequeI SequeI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing the issue

@SequeI
Copy link
Contributor

SequeI commented Nov 7, 2024

@tommyd450 If you so wish, you could add a testdata folder and add this to our new user_provided scenario so it can be tested within our CI. Can be added in another PR once we finish up other user provisioned tickets though so no worries

@tommyd450
Copy link
Contributor Author

@tommyd450 If you so wish, you could add a testdata folder and add this to our new user_provided scenario so it can be tested within our CI. Can be added in another PR once we finish up other user provisioned tickets though so no worries

Will do

@SequeI
Copy link
Contributor

SequeI commented Nov 13, 2024

@tommyd450 Please add new ctlog config to our docs since it can get pretty confusing for users with the whole setup
(When you are done of course)
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants