-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Decipher model in external #3015
base: main
Are you sure you want to change the base?
Conversation
609785f
to
2baf11d
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3015 +/- ##
==========================================
- Coverage 84.57% 84.49% -0.09%
==========================================
Files 173 178 +5
Lines 15073 15059 -14
==========================================
- Hits 12748 12724 -24
- Misses 2325 2335 +10
|
Not sure why the cuda tests are failing on import of the Decipher class. Any ideas? @canergen @ori-kron-wis |
@justjhong I updated the main branch with the updated cuda test file we need now to run on WIS servers and merged this PR with it. Now the tests work. |
CC @ANazaret
Implements Decipher model (https://github.com/azizilab/decipher, https://www.biorxiv.org/content/10.1101/2023.11.11.566719v1) into external/
For now, it only includes base implementation without many of the downstream workflows from the original implementation.
Includes minor non-breaking changes to the
LowLevelPyroTrainingPlan
.Test: was able to approximately reproduce figures from the tutorial (https://github.com/azizilab/decipher/blob/main/examples/1-tutorial.ipynb), some of the v plots for several random seeds below:
Original implementation:
New implementation: