fix(sender): nonce update

[colinlyguo]

Purpose or design rationale of this PR

Only updating nonce when sending transaction success.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

• Yes

Breaking change label

Does this PR have the breaking-change label?

• No, this PR is not a breaking change

Summary by CodeRabbit

• New Features

  • Updated version number to v4.4.82, reflecting the latest release.
  • Improved transaction sending logic to directly manage nonce, enhancing transaction reliability.

• Bug Fixes

  • Enhanced error handling and logging for transaction creation and sending processes.

• Tests

  • Updated tests to ensure correct nonce usage and transaction status tracking across various scenarios.

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for "scroll-tech/rollup/mock_bridge""
level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package : could not load export data: no export data for "scroll-tech/rollup/mock_bridge""

Walkthrough

The changes in this pull request involve updating the version tag in the common/version/version.go file from "v4.4.81" to "v4.4.82" to reflect a new release. Additionally, modifications were made to the sender package in rollup/internal/controller/sender/sender.go, which include changes to the transaction sending logic, specifically regarding nonce handling. The corresponding tests in rollup/internal/controller/sender/sender_test.go were also updated to ensure proper functionality and reliability of the transaction sending process.

Changes

File	Change Summary
common/version/version.go	Updated version tag from "v4.4.81" to "v4.4.82".
rollup/internal/controller/sender/sender.go	Updated SendTransaction and createTx methods to handle nonce directly as a uint64 instead of a pointer.
rollup/internal/controller/sender/sender_test.go	Updated tests to ensure correct nonce usage in transaction creation and improved assertions for transaction status.

Possibly related PRs

• fix(sender): make sure gas price is above baseFee #1531: Updates the version tag from "v4.4.77" to "v4.4.78".
• fix(rollup-relayer): wrong l1 messages popped num #1550: Changes the version tag from "v4.4.69" to "v4.4.70".
• fix(rollup): sender use pending block base fee #1556: Updates the version tag from "v4.4.70" to "v4.4.71".
• fix(rollup-relayer): update finalize status atomically #1558: Modifies the version tag from "v4.4.71" to "v4.4.72".
• fix(rollup-relayer): check if previous bundle or batch is finalized in fake finalize mode #1563: Updates the version tag from "v4.4.72" to "v4.4.73".
• fix(sender): graceful restart #1564: Changes the version tag from "v4.4.74" to "v4.4.75".
• fix(sender): graceful restart #1567: Updates the version tag from "v4.4.78" to "v4.4.79".
• refactor(sender): split signer address checks into gas-oracle and rollup-relayer #1568: Modifies the version tag from "v4.4.79" to "v4.4.80".

Suggested reviewers

• georgehao
• 0xmountaintop

🐇 In the code, we hop and play,
With versions changing day by day.
From four point four to eighty-two,
Our transactions now are swift and true!
With nonce in hand, we send with glee,
A brighter future, wait and see! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 06beb5d and bc1e9ad.

📒 Files selected for processing (3)

• common/version/version.go (1 hunks)
• rollup/internal/controller/sender/sender.go (3 hunks)
• rollup/internal/controller/sender/sender_test.go (3 hunks)

✅ Files skipped from review due to trivial changes (1)

• common/version/version.go

🔇 Additional comments (6)

rollup/internal/controller/sender/sender.go (3)

Line range hint 219-251: Improved nonce handling in SendTransaction

The nonce is now only incremented after successful transaction sending, which is the correct approach. This prevents nonce gaps when transactions fail to send.

---

255-256: Simplified createTx signature with direct nonce parameter

The method signature change from pointer to direct uint64 value improves clarity and safety by making the nonce parameter more explicit.

---

Line range hint 484-488: Consistent nonce handling in createReplacingTransaction

The nonce handling is consistent with the new approach, properly passing the nonce directly to createTx.

rollup/internal/controller/sender/sender_test.go (3)

285-287: Updated test to use direct nonce in createTx

Test properly reflects the new nonce handling approach in zero gas price transaction test.

---

376-378: Consistent nonce handling in non-zero gas price test

Test correctly uses the new direct nonce parameter approach.

---

423-425: Updated underpriced transaction test

Test properly implements the new nonce handling pattern.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[zimpha]

why not use signedTx.Nonce()+1 here.