Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented parsing Roman Numerals #63

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

AmPhIbIaN26
Copy link

So the parse_number() now works like this:

>>>parse_number('MMCDXX')
'2420'

And parse() works like this:

>>> parse('Built in MDCCLXXVI', language='rom')
'Built in 1776'

I have implemented parsing for roman, for the case of parsing any roman numeral in a sentence you have to specify the language.
@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #63 (4c127ec) into master (c834854) will decrease coverage by 2.03%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   98.78%   96.74%   -2.04%     
==========================================
  Files          86       87       +1     
  Lines         328      338      +10     
  Branches       60       64       +4     
==========================================
+ Hits          324      327       +3     
- Misses          1        7       +6     
- Partials        3        4       +1     
Impacted Files Coverage Δ
number_parser/parser.py 95.63% <30.00%> (-2.72%) ⬇️
number_parser/data/rom.py 100.00% <100.00%> (ø)

@AmPhIbIaN26 AmPhIbIaN26 reopened this Apr 14, 2021
I have implemented parsing for roman, for the case of parsing any roman numeral in a sentence you have to specify the language.
added encoding='utf8' to __init__.py
This reverts commit b36483e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant