Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: add one more python release to xfail list #266

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Sep 25, 2024

This should fix CI and close #265

Can be merged with a green CI.

@bsipocz bsipocz added this to the 1.3.0 milestone Sep 25, 2024
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should we just do "3.11.*" matching? Otherwise, it is going to crop back up in 3.11.11 and so on?

@bsipocz
Copy link
Member Author

bsipocz commented Sep 25, 2024

Yes, I was thinking about making it more robust, but it doesn't fail with all 3.11 releases (see my comment about not being able to reproduce locally, I was using 3.11.7).
So I would postpone a version wildcard hackary until it pops up again. The numpy ufunc test already rang a bell when I first saw the tracelog so it won't be too much of a rabbit hole to go into next time either).

@pllim pllim merged commit af2672e into scientific-python:main Sep 25, 2024
22 checks passed
@pllim
Copy link
Contributor

pllim commented Sep 25, 2024

Sounds good. Thanks!

@bsipocz bsipocz deleted the TST_add_new_python_release branch September 25, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: ci job failures failures with py311-test-pytest74 and py311-test-pytest73
2 participants