add participants count to column in batch overview #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phipsae is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
carletex
reviewed
Nov 6, 2024
Comment on lines
124
to
139
| batches.forEach( | ||
| batch => { | ||
| const batchName = batch.batchName; | ||
| participantsCounts[batchName] = 0; | ||
|
|
||
| fetchedBatchParticipants.data.forEach(builder => { | ||
| if (builder.batch && builder.batch.number === String(batchName)) { | ||
| participantsCounts[batchName]++; | ||
| } | ||
| }); | ||
| }, | ||
| [batches], | ||
| ); | ||
|
|
||
| setParticipantsCount(participantsCounts); | ||
| }, [batches, serverUrl]); |
There was a problem hiding this comment.
Damn, this nested loop is ugly haha
We are also making 3 requests to the server to render this page, which doesn't make sense.
Let's update the backend as needed so we don't need to do this. We could:
- Extend the /batches endpoint so it comes back with the count calculations
or - Create a new
/batches/statsroute that includes this data
So we'll only need to do 1 request. Also will be helpful here BuidlGuidl/buidlguidl.com#54 (comment)
…duates for each batch
|
Hey Carlos, I changed the /batches route so that it gives you the totalParticipants and graduates count for every batch. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Carlos,
I just made a small adjustment by adding the participants count next to the graduates count, so we can get a better sense of how many started and how many completed successfully (in our opinion).
Best, Philip