Silence error in GraphSheet sidebar #2633
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2601 and #2629.
The error in #2601 comes because a sheet needs to have either
default_sidebar
orguide
. Most sheets have at least a default emptyguide
because they inherit one fromTableSheet
. But there are three other subclasses ofBaseSheet
that are separate fromTableSheet
:Plotter
,TextCanvas
, andFormCanvas
.GraphSheet
comes fromPlotter
:Plotter
->Canvas
->InvertedCanvas
->GraphSheet
. So I fixed the problem by adding an empty guide toCanvas
, to head off the same issue in the several sheet types that are subclasses ofCanvas
, likeGeoJSONMap
.