[sheets-] record key-col toggle for replay as key-col-on/-off #2622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm following up on @saulpw's comment about trouble caused by keycol toggling in cmdlog replay.
Does the problem with key-col for cmdlog-replay still exist? If so, this PR should fix it, by recording
key-col-on
orkey-col-off
instead ofkey-col
.I'm preparing to submit the feature proposed in that Discussion: changing a column's sort direction while preserving other column's sort direction. So if this kind of fix is still needed for
key-col
, then I'll apply the same idea tosort-asc
and the commands like it.