[keys] use prettykeys internally for input bindings and other getkeystroke uses #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjakefala
force-pushed
the
pw24_prettykeys_internal
branch
from
13cc49c to
0b63a1b
Compare
anjakefala
reviewed
Nov 6, 2024
| elif ch in ['^J', '^M']: return True # ENTER to accept value | ||
| elif ch == '^K': v = v[:i] # ^Kill to end-of-line | ||
| elif ch == '^N': | ||
| elif ch in ('Ctrl+H', 'Bksp', 'Ctrl+?'): i -= 1; v = delchar(v, i) |
There was a problem hiding this comment.
I got "no command for Ctrl+?" when I typed Backspace
|
I also tested Spacebar is also not working. |
anjakefala
reviewed
Nov 6, 2024
| @@ -212,7 +212,6 @@ def mainloop(vd, scr): | |||
| vd.warning('duplicate prefix: ' + keystroke) | |||
| vd.keystrokes = '' | |||
| else: | |||
| keystroke = vd.prettykeys(keystroke) | |||
There was a problem hiding this comment.
It's the removal of this line that broke spacebar (' ') and the shift keys!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace legacy ^X with Ctrl+X and other curses KEY_ with internal prettykeys.
Does not replace bindings for commands, but everything else should use be using prettykeys now.