add createMatchSelector function from connected-react-router #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for this PR! Some points I'd like to care about:
|
salvoravida
reviewed
Nov 26, 2021
| let lastMatch: match<{}> | null = null; | ||
| return (state: any) => { | ||
| const { pathname } = state.router.location ?? {}; | ||
| if (pathname === lastPathname) { |
There was a problem hiding this comment.
Should use selectRouterState
There was a problem hiding this comment.
Hi, thanks for response!
Usage of selectRouterState function - done
Separated folder - it's a specially react-router function that use "matchPath" from react-router
There was a problem hiding this comment.
Does it apply only to react router v5?
There was a problem hiding this comment.
v5 and v6, used function exists in both
https://v5.reactrouter.com/web/api/matchPath
https://reactrouter.com/docs/en/v6/api#matchpath
alexplumb
reviewed
May 6, 2022
| routerReducerKey?: string; | ||
| } | ||
|
|
||
| export const createMatchSelector = (path: string, options?: Options) => { |
There was a problem hiding this comment.
The signature should also allow an array of strings (as the connected-react-router signature does)
Suggested change
| export const createMatchSelector = (path: string, options?: Options) => { | |
| export const createMatchSelector = (path: string | string[], options?: Options) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for those who used createMatchSelector function from connected-react-router