SAK-50557 LTI exceptions thrown for some tools placed in users workspace #12941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ern
changed the title
ern
reviewed
Oct 14, 2024
Comment on lines
322
to
323
| log.debug("login_hint={}", login_hint); | ||
| log.debug("encoded_login_hint={}", encoded_login_hint); |
There was a problem hiding this comment.
Suggested change
| log.debug("login_hint={}", login_hint); | |
| log.debug("encoded_login_hint={}", encoded_login_hint); | |
| log.debug("login_hint=[{}], encoded_login_hint=[{}]", login_hint, encoded_login_hint); |
ern
reviewed
Oct 14, 2024
Comment on lines
136
to
137
| log.debug("encoded_login_hint={}", encoded_login_hint); | ||
| log.debug("login_hint={}", login_hint); | ||
|
|
There was a problem hiding this comment.
@hornersa you should combine these into a single log message and differentiate it from the similar debug statement.
There was a problem hiding this comment.
I assume the class and method called (and recorded in the log statement) would distinguish one pair from another.
|
@ern - Later this morning I intend to push a new commit to incorporate your suggested revisions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://sakaiproject.atlassian.net/browse/SAK-50557
Refer to the screencast attached to the jira for details about the proposed fix.
Also, the proposed CSS change helps better align the tool title of a deployed external tool with the other tool titles in a given site's tool menu. (Currently the icon elements with class fa are two pixels too wide compared to icons with class si.)