This repository has been archived by the owner on Dec 12, 2021. It is now read-only.
Replace BCrypt::Engine with BCrypt::Password #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 8, 2011 22:14
Instead of using Engine::generate_salt and Engine::hash_secret, we can replace them with Password.create
BCrypt::Password handles the salt directly so we don't need to store it in a separate column.
|
Thanks for this. I had been meaning to add this. I am not yet certain if I want this in the next version bump or in a major release, but I hope to get it pulled in soon. |
|
I had to look into this for another project so I figured you may be able to use bits or all of it, whatever works for you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #113