Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Reuse 4 to manage licenses #1951

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Use Reuse 4 to manage licenses #1951

merged 6 commits into from
Jul 26, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jul 23, 2024

This PR introduces REUSE.toml files for managing licenses and copyright in this repository, including all the compile-time benchmarks under the collector/compile-benchmarks directory. More context can be found in #1939.

For the existing compile-time benchmarks, I used this "algorithm":

  1. If it was an artificial stress test created by rustc developers, I used the copyright The Rust Project Developers (see https://thanks.rust-lang.org) and the MIT license. Note that we couldn't use MIT OR Apache-2.0, because the compile-benchmarks directory was only licensed under MIT previously.
  2. If it was a third-party crate, I took its licenses (they were present for all the crates, luckily). As for copyright, if there was an explicit copyright in the README, I used it (this happened I think only for one crate). Otherwise, I tried to look for "XYZ developers" or something like that in the authors field of the crate's Cargo.toml. If I haven't found that, I just used <crate-name> contributors.

Fixes: #1939

@Kobzol Kobzol requested a review from pietroalbini July 23, 2024 21:28
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 24, 2024

I'm not sure if it's fine to land 6a2cba8, I don't know if e.g. GitHub recognizes REUSE.toml.

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Left one optional nit.

collector/compile-benchmarks/tt-muncher/REUSE.toml Outdated Show resolved Hide resolved
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 26, 2024

Thanks! Let's see what happens on the repo's GH homepage once the old licenses are removed.

@Kobzol Kobzol enabled auto-merge July 26, 2024 09:38
@Kobzol Kobzol merged commit b91db6a into rust-lang:master Jul 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add REUSE annotations for benchmarks in collector/compile-benchmarks
3 participants