Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REUSE annotations for benchmarks in collector/compile-benchmarks #1939

Closed
Tracked by #99414
pietroalbini opened this issue Jul 5, 2024 · 2 comments · Fixed by #1951
Closed
Tracked by #99414

Add REUSE annotations for benchmarks in collector/compile-benchmarks #1939

pietroalbini opened this issue Jul 5, 2024 · 2 comments · Fixed by #1951

Comments

@pietroalbini
Copy link
Member

The code in collector/compile-benchmarks is now a submodule of rust-lang/rust, and included in source tarballs we distribute. We thus should annotate its licensing information so that it shows up in the upcoming REUSE-powered licensing information.

Once rust-lang/rust upgrades to REUSE 4.x (which adds the new REUSE.toml), it should be possible to add a REUSE.toml in any sub-directory of collector/compile-benchmark, with a content like this:

version = 1

[[annotations]]
path = ["**"]
SPDX-FileCopyrightText = "Authorship / copyright line"
SPDX-License-Identifier = "SPDX-EXPRESSION"
@Kobzol
Copy link
Contributor

Kobzol commented Jul 22, 2024

Now that REUSE 4.0 is used in rustc, we can proceed with this. Would you prefer to put a REUSE.toml file into each compile-time benchmark directory, or have a top-level one in collector/compile-benchmarks with entries for all the benchmarks? I'd probably slightly prefer the latter, but no strong opinion.

@pietroalbini
Copy link
Member Author

Both work, I don't have a strong opinion either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants