explain some more details of the triage procedure #766
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Dylan-DPC (or someone else) some time within the next two weeks. |
rustbot
added
the
S-waiting-on-review
| `echo "$(date -I --date="$([ "z$(date +%a)" = "zMon" ] && echo 'today' || echo 'last monday')") to $(date -I --date="$([ "z$(date +%a)" = "zSun" ] && echo 'today' || echo 'next sunday')")"` | ||
|
|
||
| #### Avoiding duplicate work | ||
| If a PR's labels are still accurate, it can be worth it to remove and re-add a label in order to update the last-modified timestamp, preventing it from turning up in other triagers searches. |
There was a problem hiding this comment.
I know why triage does this trick of re-applying labels, but to a reader not familiar with the procedure this may sounds slightly unclear/generic. Can you detail why triage does this? Which label re-apply?
Example: "Since triaging is done sorting by looking at oldest issues first, re-applying the label X or Y will update an issue last-modified timestamp, signaling to other triagers that it has already been talen care of".
| @@ -130,3 +130,11 @@ each PR: | |||
|
|
|||
| Once you are done triaging PRs, post your report in the topic for the current | |||
| week's triage in the `#t-release/triage` Zulip stream. | |||
| the topic should have a name like `YYYY-MM-DD to YYYY-MM-DD`. | |||
| Note that this uses a monday-sunday week. | |||
| if a topic does not exist, you can generate it's title with | |||
There was a problem hiding this comment.
| if a topic does not exist, you can generate it's title with | |
| if a topic does not exist, you can generate its title with |
| Note that this uses a monday-sunday week. | ||
| if a topic does not exist, you can generate it's title with | ||
| the following bash oneliner (requires GNU date): | ||
| `echo "$(date -I --date="$([ "z$(date +%a)" = "zMon" ] && echo 'today' || echo 'last monday')") to $(date -I --date="$([ "z$(date +%a)" = "zSun" ] && echo 'today' || echo 'next sunday')")"` |
There was a problem hiding this comment.
I'd probably improve a little bit the formatting because the rendered markdown is a bit cluttered
There was a problem hiding this comment.
Suggestion:
echo "$(date -I --date="$([ "z$(date +%a)" = "zMon" ] && \
echo 'today' || echo 'last monday')" \
to $(date -I --date="$([ "z$(date +%a)" = "zSun" ] && \
echo 'today' || echo 'next sunday')")"
based on discussion with @Dylan-DPC