Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove once_cell #120

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Remove once_cell #120

merged 1 commit into from
Jul 15, 2024

Conversation

c410-f3r
Copy link
Contributor

In favor of LazyLock.

Needs Rustc 1.80 that will be released in ten days.

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we refactor things a bit to use std::sync::Once instead, to avoid an aggressive MSRV bump?

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Jul 15, 2024

Well, at least I tried like in rust-fuzz/arbitrary#112 🤷

Replaced with OnceLock that will be initialized as soon as rust_libfuzzer_debug_path is read in fuzz_target. This behavior differs from the current approach that will initialize only when initialize is called.

@c410-f3r c410-f3r force-pushed the master branch 2 times, most recently from 020adb4 to 0a7f0e5 Compare July 15, 2024 20:56
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen merged commit c8275d1 into rust-fuzz:main Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants