Generic format #50
Draft
Generic format #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Beyer <[email protected]>
This patch implements config format specification by providing generic arguments to the API functions. The type provided in the generic argument implements the deserialization technique. The example was adapted. Signed-off-by: Matthias Beyer <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a generic type parameter to specify the deserialization format.
This PR is not ready yet, and - maybe more importantly - is a draft because I just want to propose this. I'm not 100% happy with how the API looks!
Lets discuss whether something like this is an idea. Maybe we could change the API so that not a generic argument is passed, but an actual object, to make the API a bit easier to use...?
This includes #49