Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: receive warnings from dbms server in neo4j queries #16598

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

nightosong
Copy link
Contributor

Description

When I used neo4j graph store, I received numbers of warnings, as shown below:

Received notification from DBMS server: {severity: WARNING} {code: Neo.ClientNotification.Statement.FeatureDeprecationWarning} {category: DEPRECATION} {title: This feature is deprecated and will be removed in future versions.} {description: The procedure has a deprecated field. ......

Fixes # (issue)

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 18, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 18, 2024
@logan-markewich
Copy link
Collaborator

I would love unit tests on this someday. I wish neo4j had an in-process mode for tests

@logan-markewich logan-markewich merged commit bdd4dd2 into run-llama:main Oct 18, 2024
10 of 11 checks passed
@rbrugaro
Copy link
Contributor

@logan-markewich this PR is causing regression
Screenshot 2024-10-18 at 2 01 22 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants