Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to fail if ignored identifiers weren't seen #339

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bschmeck
Copy link

I frequently use bundler-audit as a step in my CI/CD pipeline and will add an identifier to the ignore list to acknowledge that I know about the vulnerability but aren't able to upgrade the gem yet. In order to keep that list of ignored CVEs manageable, I would like bundler-audit to (optionally) fail if I've ignored an identifier but the scan did not find that identifier. This would force me to clean up the list of ignored identifiers after upgrading a gem.

This change will only output a warning message when using the text format because I couldn't think of a non-breaking way to add it to the JSON and XML outputs. Maybe the option should be restricted to just the text format? It would probably be annoying to return an error code without providing an explanation about why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant