Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move actions to subnav #644

Merged
merged 5 commits into from
Jul 3, 2018
Merged

move actions to subnav #644

merged 5 commits into from
Jul 3, 2018

Conversation

lislis
Copy link
Member

@lislis lislis commented Jun 5, 2018

Is this solving an issue already in our backlog? If so, please mention which one

It belongs to #597

Before

screenshot-2018-6-5 rorganize it find a rails girls study group 1

After

screenshot-2018-6-5 rorganize it find a rails girls study group

@PragTob
Copy link
Member

PragTob commented Jun 12, 2018

👍

Looking good, the "account linked with github" looks a bit too much like a menu item imo though so I'd expect to be able to click it? Maybe we just remove it from there and display it somewhere else?

@lislis
Copy link
Member Author

lislis commented Jun 13, 2018

I had the same feeling.
Maybe it's better to move the information to the edit page anyway? Give it a box for 'Link account to GH | Account linked with GH'

@PragTob
Copy link
Member

PragTob commented Jun 13, 2018

I think that's a good idea, yeah!

@lislis
Copy link
Member Author

lislis commented Jul 3, 2018

moved the GH account linking to person#edit

screenshot-2018-7-3 rorganize it find a rails girls study group 1
screenshot-2018-7-3 rorganize it find a rails girls study group

@lislis lislis merged commit be83d21 into master Jul 3, 2018
@lislis lislis deleted the 597-move-actions-to-subnav branch July 3, 2018 19:15
@lislis
Copy link
Member Author

lislis commented Jul 3, 2018

MERGING THIS
selfmerge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants