-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specs for Random::Formatter#alphanumeric #1222
Open
herwinw
wants to merge
1
commit into
ruby:master
Choose a base branch
from
herwinw:random_alphanumeric
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
require_relative '../../spec_helper' | ||
|
||
ruby_version_is "3.1" do | ||
require 'random/formatter' | ||
|
||
describe "Random.alphanumeric" do | ||
it "generates a random alphanumeric string" do | ||
Random.alphanumeric.should =~ /\A[A-Za-z0-9]+\z/ | ||
end | ||
|
||
it "has a default size of 16 characters" do | ||
Random.alphanumeric.size.should == 16 | ||
end | ||
|
||
it "accepts a 'size' argument" do | ||
Random.alphanumeric(10).size.should == 10 | ||
end | ||
|
||
it "uses the default size if 'nil' is given as size argument" do | ||
Random.alphanumeric(nil).size.should == 16 | ||
end | ||
|
||
it "raises an ArgumentError if the size is not numeric" do | ||
-> { | ||
Random.alphanumeric("10") | ||
}.should raise_error(ArgumentError) | ||
end | ||
|
||
it "does not coerce the size argument with #to_int" do | ||
size = mock("size") | ||
size.should_not_receive(:to_int) | ||
-> { | ||
Random.alphanumeric(size) | ||
}.should raise_error(ArgumentError) | ||
end | ||
|
||
it "can be used by any object that responds to #random_number" do | ||
random = mock("random") | ||
random.should_receive(:random_number).and_return(42) | ||
random.extend(Random::Formatter) | ||
random.alphanumeric(2).should == "qA" | ||
end | ||
|
||
ruby_version_is "3.3" do | ||
it "accepts a 'chars' argument with the output alphabet" do | ||
Random.alphanumeric(chars: ['a', 'b']).should =~ /\A[ab]+\z/ | ||
end | ||
|
||
it "converts the elements of chars using #to_s" do | ||
to_s = mock("to_s") | ||
to_s.should_receive(:to_s).and_return("[mock to_s]") | ||
# Using 1 value in chars results in an infinite loop | ||
Random.alphanumeric(1, chars: [to_s, to_s]).should == "[mock to_s]" | ||
end | ||
end | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems |
||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like
Random::Formatter
was available in Ruby 3.0 but was part ofsecurerandom
.https://github.com/ruby/ruby/blob/v3_1_0/NEWS.md
https://bugs.ruby-lang.org/issues/18190
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it seems
Random::Formatter
's methods are available onSecureRandom
. So ideally we would want to have a shared example to test#alphanumeric
for bothRandom::Formatter
andSequreRandom
.JFYI there are specs of
Random::Formatter
methods in https://github.com/ruby/spec/tree/master/library/securerandom that would probably also might be shared.