Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isinf is available on MSVC #3274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

isinf is available on MSVC #3274

wants to merge 1 commit into from

Conversation

nobu
Copy link
Member

@nobu nobu commented Dec 3, 2024

At least Visual Studio 2015 (MSVC 14.0) provides the macro conforming to C99.
And, float.h is necessary to use _finite() like the current code.

At least Visual Studio 2015 (MSVC 14.0) provides the macro conforming
to C99.
@nobu
Copy link
Member Author

nobu commented Dec 4, 2024

I see, the problem is mingw, not mswin.

https://github.com/ruby/prism/actions/runs/12141353366/job/33853261523?pr=3274#step:4:37

src/prism.c:4145:34: error: conversion from 'double' to 'float' may change value [-Werror=float-conversion]
 4145 |     if (errno == ERANGE && isinf(value)) {
      |                                  ^~~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant