Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compatible function pointer types to fix build errors on newer Clang #26

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

jeremy
Copy link
Contributor

@jeremy jeremy commented Jul 31, 2024

Fixes #25

@hsbt hsbt force-pushed the incompatible-function-pointer-types branch from 348b6ee to 7200324 Compare August 1, 2024 05:51
@hsbt
Copy link
Member

hsbt commented Aug 1, 2024

Thanks!

@hsbt hsbt merged commit 90e03d2 into ruby:master Aug 1, 2024
34 checks passed
@jeremy jeremy deleted the incompatible-function-pointer-types branch August 1, 2024 15:15
@noma4i
Copy link

noma4i commented Aug 13, 2024

Will it be released to rubygems?

@Adrian-Hirt
Copy link

@hsbt Any updates on this? Please let me know if I can be of any assistance.

@hsbt
Copy link
Member

hsbt commented Sep 12, 2024

https://rubygems.org/gems/iconv/versions/1.1.0
https://github.com/ruby/iconv/releases/tag/v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fails to build on ruby 3.3 with clang-1500.3.9.4
4 participants