Skip to content
This repository has been archived by the owner on Oct 19, 2018. It is now read-only.

Added to_key methods and tests #254

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Conversation

Donnadieu
Copy link
Contributor

No description provided.

Copy link
Contributor

@catmando catmando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job...
I will fix this but be careful to remove "pause" from tests

@catmando catmando merged commit ccdf5cc into ruby-hyperloop:edge Feb 21, 2018
@Donnadieu
Copy link
Contributor Author

Donnadieu commented Feb 21, 2018 via email

@sfcgeorge
Copy link

Using this now, works nicely :)

In future could add this so that the same OOID will be seen in Components and Hyper Mesh (note using the backing_record OOID)

# don't think this is the best class to put it in,
# should probably be client only in an RR class 
class ActiveRecord::Base
  def to_key
    backing_record.object_id
  end
end

E.g. you use it in a component with a record Foo(id: "foo-#{foo.to_key}")

@catmando
Copy link
Contributor

catmando commented Mar 6, 2018

@sfcgeorge this has been closed by ruby-hyperloop/hyper-mesh#61 its currently on edge

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants