Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation msg + small refactor #2502

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Remove deprecation msg + small refactor #2502

merged 2 commits into from
Oct 1, 2024

Conversation

ericproulx
Copy link
Contributor

@ericproulx ericproulx commented Oct 1, 2024 •
edited
Loading

This PR will remove the deprecation message when options and block are used simultaneously when describing an API through the DSL function desc.

@ericproulx ericproulx marked this pull request as ready for review October 1, 2024 15:12
@ericproulx ericproulx requested a review from dblock October 1, 2024 15:15
@dblock dblock merged commit 5b0066c into ruby-grape:master Oct 1, 2024
56 checks passed
@ericproulx ericproulx deleted the remove_desc_deprecation branch October 6, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericproulx @dblock