Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EISO8601-IN25: Unhelpful TODO output from decoder failure #27

Merged
merged 1 commit into from
Jun 13, 2021
Merged

EISO8601-IN25: Unhelpful TODO output from decoder failure #27

merged 1 commit into from
Jun 13, 2021

Conversation

jamesrweb
Copy link
Contributor

@jamesrweb jamesrweb commented May 21, 2021

Fixes #25 by adding the implementation of deadEndsToString from elm/parser PR 16 to provide much clearer end user output of errors until such times as the parser module finally gets an update.. 💭

@jamesrweb
Copy link
Contributor Author

@rtfeldman any chance you could review this? I have an issue on a project with dead ends and clearer output would help me a lot from the library side 😅

Copy link
Owner

@rtfeldman rtfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks @jamesrweb! ❤️

@rtfeldman rtfeldman merged commit 2ac1bf1 into rtfeldman:master Jun 13, 2021
@jamesrweb
Copy link
Contributor Author

Thanks @rtfeldman! 🍾

@jamesrweb jamesrweb deleted the EISO8601-IN25 branch June 13, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhelpful TODO output from decoder failure
2 participants