Fix error messages in onError
and in onNext
#205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State error messages
Flowable: Invalid call to onXxx(): onComplete/onError was already called.'
/Flowable: Invalid call to onXxx(): onSubscribe has not been called.'
are printed correctly now inonError
andonNext
methods.Motivation:
Previously, state error message
Flowable: Invalid call to onXxx(): onSubscribe has not been called.'
was printed always regardles of the actual state ofFlowableSubscriber
. Even on attempt to operate onFlowableSubscriber
when flow was completed already (either by prior call toonError
oronComplete
method).Note: State error message in
onComplete
method works correctly already.Modifications:
Checks for
this._active
are replaced withthis._started
.Result:
State error message
Flowable: Invalid call to onXxx(): onComplete/onError was already called.'
is printed on attempt to operate onFlowableSubscriber
when flow is completed already.