Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust payload keep alive values to be in ms #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petragabriela
Copy link

Changing the keep alive interval and keep alive max lifetime values to be in milliseconds according to the documented protocol.

Motivation:

Currently, the master branch is not really usable because the setup payload sent to a server includes a max lifetime value in seconds while it should be in milliseconds according to the protocol. As a result, the channel will be prematurely closed before the client can receive the response.

Modifications:

  • Added Ms to instances variables related to the keep-alive for better clarity
  • Changed their default values to be in milliseconds
  • Changed the keep-alive timer param to be in milliseconds
  • Minor fix in WebSocketRSocketResponder: add casting

Result:

No breaking change is expected, the keepAlive setter of the RSocketConnector class still receives the params in seconds unit.
Now RSocket channels should not be prematurely closed.

References:

Protocol Doc
Kotlin SDK
Go SDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant