fix: adjust payload keep alive values to be in ms #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the keep alive interval and keep alive max lifetime values to be in milliseconds according to the documented protocol.
Motivation:
Currently, the master branch is not really usable because the setup payload sent to a server includes a max lifetime value in seconds while it should be in milliseconds according to the protocol. As a result, the channel will be prematurely closed before the client can receive the response.
Modifications:
Ms
to instances variables related to the keep-alive for better clarityWebSocketRSocketResponder
: add castingResult:
No breaking change is expected, the
keepAlive
setter of theRSocketConnector
class still receives the params in seconds unit.Now RSocket channels should not be prematurely closed.
References:
Protocol Doc
Kotlin SDK
Go SDK