Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various bug-fixes #270

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

various bug-fixes #270

wants to merge 8 commits into from

Conversation

rosepearson
Copy link
Owner

@rosepearson rosepearson commented Nov 20, 2024 •
edited
Loading

Changes:

  • Fix lake behaviour
  • Optimise chunked calculations when noting is in ROI
  • Rivers accidental upstream -
  • Rivers fans crossed - 15059243, 11016624
  • River mouth support for points not contours -
  • Rivers - non land intersect option for fans
  • Turn off rivers geometry errors ignore

Check list:

  • Make code change
  • Update tests
    • Update / create new tests
    • Ensure these tests have the expected behavour
    • Test locally and ensure tests are passing
  • Ensure tests passing on GH Actions
  • Update documentation
    • Doc strings
    • Wiki
  • Update package (version.py & pyproject.toml) version (if needed)

@rosepearson rosepearson linked an issue Nov 20, 2024 that may be closed by this pull request
bugfixes various #269
Open
@rosepearson
Copy link
Owner Author

Changes:

  • Fix lake behaviour
  • Optimise chunked calculations when noting is in ROI - replace dask.empty with dask.full(shape, numpy.nan)
  • Rivers accidental upstream -
  • Rivers fans crossed - 15059243, 11016624
  • River mouth support for points not contours -
  • Rivers - non land intersect option for fans

Check list:

  • Make code change

  • Update tests

    • Update / create new tests
    • Ensure these tests have the expected behavour
    • Test locally and ensure tests are passing

  • Ensure tests passing on GH Actions

  • Update documentation

    • Doc strings
    • Wiki

  • Update package (version.py & pyproject.toml) version (if needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bugfixes various
1 participant
@rosepearson