Implementing EntityKeyValues #615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KillStr3aK
commented
Oct 8, 2024
Comment on lines
+452
to
+456
| if (type == typeof(Color)) | ||
| { | ||
| var pointer = (IntPtr)GetResult(typeof(IntPtr), ptr); | ||
| return Marshaling.ColorMarshaler.NativeToManaged(pointer); | ||
| } |
There was a problem hiding this comment.
This one should be there since the beginning I believe haha
KillStr3aK
commented
Oct 8, 2024
Comment on lines
+460
to
+463
| if (type == typeof(CEntityHandle)) | ||
| { | ||
| return new CEntityHandle((uint)GetResult(typeof(uint), ptr)); | ||
| } |
There was a problem hiding this comment.
I hope this one fits?
KillStr3aK
commented
Oct 8, 2024
|
|
||
| case counterstrikesharp::TYPE_COLOR: | ||
| { | ||
| script_context.SetResult(new Color(keyValues->GetColor(key))); |
KillStr3aK
commented
Oct 8, 2024
Comment on lines
+506
to
+536
| script_context.SetResult(new Vector(keyValues->GetVector(key))); | ||
| break; | ||
| } | ||
|
|
||
| case counterstrikesharp::TYPE_VECTOR2D: | ||
| { | ||
| script_context.SetResult(new Vector2D(keyValues->GetVector2D(key))); | ||
| break; | ||
| } | ||
|
|
||
| case counterstrikesharp::TYPE_VECTOR4D: | ||
| { | ||
| script_context.SetResult(new Vector4D(keyValues->GetVector4D(key))); | ||
| break; | ||
| } | ||
|
|
||
| case counterstrikesharp::TYPE_QUATERNION: | ||
| { | ||
| script_context.SetResult(new Quaternion(keyValues->GetQuaternion(key))); | ||
| break; | ||
| } | ||
|
|
||
| case counterstrikesharp::TYPE_QANGLE: | ||
| { | ||
| script_context.SetResult(new QAngle(keyValues->GetQAngle(key))); | ||
| break; | ||
| } | ||
|
|
||
| case counterstrikesharp::TYPE_MATRIX3X4: | ||
| { | ||
| script_context.SetResult(new matrix3x4_t(keyValues->GetMatrix3x4(key))); |
There was a problem hiding this comment.
These should not leak with #613 because the wrapper classes will be DisposableMemory and when its no longer used on the managed side these pointers are released
KillStr3aK
commented
Oct 8, 2024
Comment on lines
+48
to
+66
| Vector2D* Vector2DNew(ScriptContext& script_context) | ||
| { | ||
| return new Vector2D(); | ||
| } | ||
|
|
||
| Vector4D* Vector4DNew(ScriptContext& script_context) | ||
| { | ||
| return new Vector4D(); | ||
| } | ||
|
|
||
| matrix3x4_t* Matrix3x4New(ScriptContext& script_context) | ||
| { | ||
| return new matrix3x4_t(); | ||
| } | ||
|
|
||
| Quaternion* QuaternionNew(ScriptContext& script_context) | ||
| { | ||
| return new Quaternion(); | ||
| } |
KillStr3aK
changed the title
KillStr3aK
commented
Oct 8, 2024
|
|
||
| CEntityKeyValues* EntityKeyValuesNew(ScriptContext& script_context) | ||
| { | ||
| return new CEntityKeyValues(); |
There was a problem hiding this comment.
forgot to mention that this one is also will be released with #613
…`, `matrix3x4_t`
KillStr3aK
force-pushed
the
feature/entitykeyvalues
branch
from
293a3a8 to
7d346df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly based on #440 by @Yarukon
Implemented
CEntityKeyValues, can be used like:This is also possible:
Also implemented some of the math related classes minimally, however: we need #613 in order to prevent memory leaks related to them. (changes needed later on if this one gets merged earlier, or I can make the adjustments on this if 613 is merged.)