-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for prerotate script (#22) #23
base: master
Are you sure you want to change the base?
Conversation
Just wanted to update to say that I have continued trying to get molecule working with the docker driver, and that I am still stuck. I posted a request for help regarding my problems with molecule on the ansible forum, you'll find it here: https://forum.ansible.com/t/critical-driver-docker-from-state-file-users-myusername-cache-molecule-ansible-role-logrotate-default-state-yml-is-not-available/5979 |
Looks good, let's wait for CI. I'll change |
I wonder if the failures in these tests related to this bug, ansible-community/molecule-plugins#256 |
@robertdebock I've just linked an issue that was found yesterday in molecule-plugins - I'm wondering if that might be the cause of these test failures. Sadly, despite my best efforts, I still can't get molecule working on my machine. Proof, if you need it that I am still trying is here on Reddit, and here on the ansible forum. |
fba8e2e
to
a80d870
Compare
I've pushed a fix for the duplicate files issue. |
a80d870
to
347fd32
Compare
|
@robertdebock |
name: Add prerotate
about: logrotate allows for a user to specify a script that can be run before the rotate process runs. This change adds that functionality to this role.
Describe the change
I've copied the postrotate feature, and its tests, and duplicated it as prerotate.
Testing
Unfortunately, despite my efforts, I haven't been able to get molecule running with docker locally, and so I haven't been able to run the tests. It seems that docker-py 2.32.0 / requests has a an issue with ansible 9.6. I've tried upgrading to ansible 10.0.0b1, but I still haven't been able to get it to work.