Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Android devices #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasondelport
Copy link

Changed some Java code that wasn't supported on older versions of Android

Fixed an issue that was causing errors when scanning Barcodes on Android devices

Fixed an issue with Android embedding v2 in the example

Updated to latest version of native_device_orientation

Changed some Java code that wasn't supported on older versions of Android

Fixed an issue that was causing errors when scanning Barcodes on Android devices

Fixed an issue with Android embedding v2 in the example

Updated to latest version of native_device_orientation
@rmtmckenzie
Copy link
Owner

Thanks for the PR. There was a reason why I had the frames closing then, I think possibly a memory leak - I'll try to take a look to make sure that removing it doesn't break anything else before merging this. I should have some time to look into this on the weekend.

@SoftWyer
Copy link

SoftWyer commented Aug 20, 2022

This PR probably needs to implement the OnCompleteListener to close the frame. See this example.

DeividAndreola added a commit to dblinks/flutter_qr_mobile_vision that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants