Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve apa102 display fcn #296

Merged
merged 5 commits into from
Nov 3, 2024
Merged

improve apa102 display fcn #296

merged 5 commits into from
Nov 3, 2024

Conversation

markoaurelije
Copy link
Contributor

Actually for APA102 LEDs, the start-frame needs to be zeros of 32bit size. For the end-frame n/2 bits needs to be written (n is size of apa102 strip. This improvement reduces the bytes needed to be written resulting in notable increase of speed.

markoaurelije and others added 2 commits November 2, 2024 21:47
Actually for APA102 LEDs, the start-frame needs to be zeros of 32bit size.
For the end-frame n/2 bits needs to be written (n is size of apa102 strip.
This improvement reduces the bytes needed to be written resulting in notable increase of speed.
@rm-hull
Copy link
Owner

rm-hull commented Nov 2, 2024

Tests fail

@markoaurelije
Copy link
Contributor Author

Thx, now it should work.
Here is the article this is based on: https://www.pololu.com/product/2556
also your tech-spec/APA102 has similar info about the length of start and end frames.

Copy link
Owner

@rm-hull rm-hull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a worthwhile change .. to paraphrase, rather than creating a buffer of 3n, it just creates a smaller buffer 4 + n + n/2, populates data at offset 4 onwards. It still has the same effect in that it correctly resets the pixels, but takes significantly less time due to the smaller reset data.

@rm-hull rm-hull merged commit 35d1842 into rm-hull:main Nov 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants