Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rz_pvector_foreach_cpp for bf->o->sections #339

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Jan 13, 2024

This pr fixes the following error in the Rizin CI build, likely due to rizinorg/rizin#4089:

rz_list_foreach_cpp-error
(https://github.com/rizinorg/rizin/actions/runs/7508868696/job/20446293652#step:9:11855)

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cutter also needs to be fixed afterwards:

 #9 ERROR: process "/bin/sh -c cd /root && \tgit clone --recurse-submodules --depth 1 https://github.com/rizinorg/cutter && \tcd cutter && \tcmake -Bbuild -GNinja -DCUTTER_USE_BUNDLED_RIZIN=OFF -DCMAKE_INSTALL_PREFIX=/usr && \tninja -C build && \tninja -C build install" did not complete successfully: exit code: 1
------
 > [5/5] RUN cd /root && 	git clone --recurse-submodules --depth 1 https://github.com/rizinorg/cutter && 	cd cutter && 	cmake -Bbuild -GNinja -DCUTTER_USE_BUNDLED_RIZIN=OFF -DCMAKE_INSTALL_PREFIX=/usr && 	ninja -C build && 	ninja -C build install:
26.16 ../src/core/Cutter.cpp: In member function 'QList<SegmentDescription> CutterCore::getAllSegments()':
26.16 ../src/core/Cutter.cpp:3497:56: error: cannot convert 'RzPVector*' {aka 'rz_pvector_t*'} to 'RzList*' {aka 'rz_list_t*'} in initialization
26.16      RzList *segments = rz_bin_object_get_segments(bf->o);
26.16                                                         ^

@kazarmy
Copy link
Member Author

kazarmy commented Jan 13, 2024

Okay

@kazarmy kazarmy merged commit 3fb97d1 into rizinorg:dev Jan 13, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants