Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPDX copyright text #760

Merged
merged 2 commits into from
Mar 5, 2021
Merged

SPDX copyright text #760

merged 2 commits into from
Mar 5, 2021

Conversation

ret2libc
Copy link
Member

@ret2libc ret2libc commented Mar 4, 2021

Partially addresses #683

@XVilka XVilka added this to the 0.2.0 milestone Mar 4, 2021
librz/analysis/p/analysis_rsp.c Outdated Show resolved Hide resolved
librz/asm/arch/8051/8051_ass.c Outdated Show resolved Hide resolved
librz/asm/arch/pyc/opcode.h Outdated Show resolved Hide resolved
librz/asm/arch/rsp/rsp_idec.c Outdated Show resolved Hide resolved
librz/asm/arch/ppc/libvle/vle.c Outdated Show resolved Hide resolved
librz/asm/arch/ppc/libps/libps_internal.h Outdated Show resolved Hide resolved
librz/asm/arch/ppc/libps/libps.h Outdated Show resolved Hide resolved
librz/asm/arch/ppc/libps/libps.c Outdated Show resolved Hide resolved
librz/asm/p/asm_x86_vm.c Outdated Show resolved Hide resolved
librz/util/asn1.c Outdated Show resolved Hide resolved
librz/util/astr.c Outdated Show resolved Hide resolved
librz/util/pkcs7.c Outdated Show resolved Hide resolved
librz/util/protobuf.c Outdated Show resolved Hide resolved
librz/util/x509.c Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #760 (23b559f) into dev (dd4b884) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #760      +/-   ##
==========================================
- Coverage   42.81%   42.78%   -0.04%     
==========================================
  Files         871      871              
  Lines      316895   316894       -1     
==========================================
- Hits       135678   135581      -97     
- Misses     181217   181313      +96     
Impacted Files Coverage Δ
binrz/rizin/rizin.c 8.10% <ø> (ø)
binrz/rz-agent/rz-agent.c 100.00% <ø> (ø)
binrz/rz-asm/rz-asm.c 100.00% <ø> (ø)
binrz/rz-ax/rz-ax.c 100.00% <ø> (ø)
binrz/rz-bin/rz-bin.c 100.00% <ø> (ø)
binrz/rz-diff/rz-diff.c 100.00% <ø> (ø)
binrz/rz-find/rz-find.c 100.00% <ø> (ø)
binrz/rz-gg/rz-gg.c 100.00% <ø> (ø)
binrz/rz-hash/rz-hash.c 100.00% <ø> (ø)
binrz/rz-run/rz-run.c 100.00% <ø> (ø)
... and 759 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd4b884...23b559f. Read the comment docs.


import argparse
import os
import sys

import yaml

CMDDESCS_C_TEMPLATE = """// SPDX-License-Identifier: LGPL-3.0-only
CMDDESCS_C_TEMPLATE = """// SPDX-FileCopyrightText: 2020 RizinOrg <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPDX-FileCopyrightText: 2020-{current_year} RizinOrg <[email protected]> mabye

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just didn't want to update this every year :D I don't think it's mandatory to have a range

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is wrong. we should update this based on changes. so every time we update the commands, the files needs to be regenerated (therefore also the header like you normally would do for any fix).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put RIzinOrg instead of my name or the name of someone else to avoid having to adapt this line every time one adds a bunch of commands.

@XVilka
Copy link
Member

XVilka commented Mar 5, 2021

Could you please add a paragraph about those licenses/SPDX headers in:

  • PACKAGERS.md
  • CONTRIBUTORS.md (or DEVELOPERS.md)

Copy link
Member

@thestr4ng3r thestr4ng3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not use Public Domain on anything. Better put LGPL-3.0-only if in doubt.

.reuse/dep5 Outdated Show resolved Hide resolved
@ret2libc
Copy link
Member Author

ret2libc commented Mar 5, 2021

I would not use Public Domain on anything. Better put LGPL-3.0-only if in doubt.

Ok, done. Only CC0 remaining is for librz/search/aes-find.c, because it is not our code and the author said This source is public domain. Feel free to use it and distribute it

ret2libc and others added 2 commits March 5, 2021 18:21
- Add LICENSES directory
- Download additional licenses used
- Add .reuse directory
- Add doc about SPDX/reuse

Co-authored-by: Florian Märkl <[email protected]>
@XVilka XVilka merged commit 53bf5c4 into dev Mar 5, 2021
@XVilka XVilka deleted the spdx-copyright branch March 5, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants