-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPDX copyright text #760
SPDX copyright text #760
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #760 +/- ##
==========================================
- Coverage 42.81% 42.78% -0.04%
==========================================
Files 871 871
Lines 316895 316894 -1
==========================================
- Hits 135678 135581 -97
- Misses 181217 181313 +96
Continue to review full report at Codecov.
|
|
||
import argparse | ||
import os | ||
import sys | ||
|
||
import yaml | ||
|
||
CMDDESCS_C_TEMPLATE = """// SPDX-License-Identifier: LGPL-3.0-only | ||
CMDDESCS_C_TEMPLATE = """// SPDX-FileCopyrightText: 2020 RizinOrg <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPDX-FileCopyrightText: 2020-{current_year} RizinOrg <[email protected]>
mabye
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just didn't want to update this every year :D I don't think it's mandatory to have a range
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is wrong. we should update this based on changes. so every time we update the commands, the files needs to be regenerated (therefore also the header like you normally would do for any fix).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put RIzinOrg instead of my name or the name of someone else to avoid having to adapt this line every time one adds a bunch of commands.
Could you please add a paragraph about those licenses/SPDX headers in:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not use Public Domain on anything. Better put LGPL-3.0-only
if in doubt.
Ok, done. Only CC0 remaining is for librz/search/aes-find.c, because it is not our code and the author said |
- Add LICENSES directory - Download additional licenses used - Add .reuse directory - Add doc about SPDX/reuse Co-authored-by: Florian Märkl <[email protected]>
Partially addresses #683