Rizin as subproject

[amibranch]

Your checklist for this pull request

• I've read the guidelines for contributing to this repository
• I made sure to follow the project's coding style
• I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
• I've added tests that prove my fix is effective or that my feature works (if possible)
• I've updated the rizin book with the relevant information (if needed)

Detailed description

Added some minor fixes that are relevant, if rizin is used as subproject:

• Added extern "C" linkage specification to some public headers of rizin (not specifically relevant for meson, but became necessary in a used project)
• Replaced add_global_link_arguments with add_project_link_arguments (for the same reason, as why add_*_arguments have been replaced)
• Changed the meson_git_wrapper.py-script to explicitly specify the output-path, as currently the pwd is chosen (which is always the top-build-dir. This leads to several problems, if used in subprojects (where the top rizin-build-dir is NOT the top build-dir)
• Made the RIZIN_BUILD_PATH conditional in the integration-test meson-build, as this makes problems in subprojects that do not configure the cli-option

Some minor fixes to comply with CI

• Removed a native-arg that is not allowed and should not have any effect in declare_dependency
• Exchanged the c_std default options for libzip, rzar and rzwinkd to be gnu99, as otherwise compile-errors occurred with glibc

Test plan

TODO (mainly CI)
...

Closing issues

...

[XVilka]

@amibranch it breaks Windows builds:

FAILED: subprojects/libzip-1.9.2/liblibzip.a.p/meson-generated_.._zip_err_str.c.obj 
"cl" "-Isubprojects\libzip-1.9.2\liblibzip.a.p" "-Isubprojects\libzip-1.9.2" "-I..\subprojects\libzip-1.9.2" "-I..\subprojects\libzip-1.9.2\lib" "-Isubprojects\zlib-1.2.13" "-I..\subprojects\zlib-1.2.13" "/MT" "/nologo" "/showIncludes" "/utf-8" "/W2" "/O2" "/Gw" "/Fdsubprojects\libzip-1.9.2\liblibzip.a.p\meson-generated_.._zip_err_str.c.pdb" /Fosubprojects/libzip-1.9.2/liblibzip.a.p/meson-generated_.._zip_err_str.c.obj "/c" subprojects/libzip-1.9.2/zip_err_str.c
c:\projects\rizin\build\subprojects\libzip-1.9.2\zipconf.h(18): fatal error C1017: invalid integer constant expression
[200/1973] Compiling C object subprojects/xz-5.4.3/src/liblzma/liblzma.a.p/lzma_lzma_decoder.c.obj
[201/1973] Compiling C object subprojects/libzip-1.9.2/liblibzip.a.p/lib_zip_add.c.obj
FAILED: subprojects/libzip-1.9.2/liblibzip.a.p/lib_zip_add.c.obj 
"cl" "-Isubprojects\libzip-1.9.2\liblibzip.a.p" "-Isubprojects\libzip-1.9.2" "-I..\subprojects\libzip-1.9.2" "-I..\subprojects\libzip-1.9.2\lib" "-Isubprojects\zlib-1.2.13" "-I..\subprojects\zlib-1.2.13" "/MT" "/nologo" "/showIncludes" "/utf-8" "/W2" "/O2" "/Gw" "/Fdsubprojects\libzip-1.9.2\liblibzip.a.p\lib_zip_add.c.pdb" /Fosubprojects/libzip-1.9.2/liblibzip.a.p/lib_zip_add.c.obj "/c" ../subprojects/libzip-1.9.2/lib/zip_add.c
c:\projects\rizin\build\subprojects\libzip-1.9.2\zipconf.h(18): fatal error C1017: invalid integer constant expression
ninja: build stopped: subcommand failed.

[XVilka]

Also pylint complains:

Run export PATH=${HOME}/Library/Python/3.9/bin:${HOME}/Library/Python/3.10/bin:${HOME}/.local/bin:${PATH}
pylint: Command line or configuration file:1: UserWarning: 'BaseException' is not a proper value for the 'overgeneral-exceptions' option. Use fully qualified name (maybe 'builtins.BaseException' ?) instead. This will cease to be checked at runtime when the configuration upgrader is released.
pylint: Command line or configuration file:1: UserWarning: 'Exception' is not a proper value for the 'overgeneral-exceptions' option. Use fully qualified name (maybe 'builtins.Exception' ?) instead. This will cease to be checked at runtime when the configuration upgrader is released.
************* Module gdbserver
test/scripts/gdbserver.py:25:8: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from)
************* Module fuzz_rz_asm
test/fuzz/scripts/fuzz_rz_asm.py:137:11: E0606: Possibly using variable 'sys' before assignment (possibly-used-before-assignment)
************* Module meson_git_wrapper
sys/meson_git_wrapper.py:61:8: E1124: Argument 'output_path' passed by position and keyword in function call (redundant-keyword-arg)
sys/meson_git_wrapper.py:61:47: E0602: Undefined variable 'gittip_dir' (undefined-variable)
************* Module rzshell_which
librz/core/cmd_descs/rzshell_which.py:16:4: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from)

-----------------------------------
Your code has been rated at 9.80/10

[amibranch]

Also pylint complains:

Run export PATH=${HOME}/Library/Python/3.9/bin:${HOME}/Library/Python/3.10/bin:${HOME}/.local/bin:${PATH}
pylint: Command line or configuration file:1: UserWarning: 'BaseException' is not a proper value for the 'overgeneral-exceptions' option. Use fully qualified name (maybe 'builtins.BaseException' ?) instead. This will cease to be checked at runtime when the configuration upgrader is released.
pylint: Command line or configuration file:1: UserWarning: 'Exception' is not a proper value for the 'overgeneral-exceptions' option. Use fully qualified name (maybe 'builtins.Exception' ?) instead. This will cease to be checked at runtime when the configuration upgrader is released.
************* Module gdbserver
test/scripts/gdbserver.py:25:8: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from)
************* Module fuzz_rz_asm
test/fuzz/scripts/fuzz_rz_asm.py:137:11: E0606: Possibly using variable 'sys' before assignment (possibly-used-before-assignment)
************* Module meson_git_wrapper
sys/meson_git_wrapper.py:61:8: E1124: Argument 'output_path' passed by position and keyword in function call (redundant-keyword-arg)
sys/meson_git_wrapper.py:61:47: E0602: Undefined variable 'gittip_dir' (undefined-variable)
************* Module rzshell_which
librz/core/cmd_descs/rzshell_which.py:16:4: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from)

-----------------------------------
Your code has been rated at 9.80/10

I guess this was introduced by one of the rebase-actions by myself. Will be fixed in a next push to this PR: #4680 (I rather want to work on a rebased state, to avoid any regressions). However, I just want to wait for all CI-Results - just in case

[wargio]

Suggested change

	libzip_dep = dependency('libzip', required: get_option('use_sys_libzip'), static: is_static_build, default_options: [ 'c_std=gnu99' ])
	libzip_dep = dependency('libzip', required: get_option('use_sys_libzip'), static: is_static_build, default_options: [ 'c_std=gnu99,c99' ])

Add also c99 as fallback, otherwise it will not compile on MSVC

[amibranch]

needed to make it conditional, as muon would throw an error:

/home/runner/work/rizin/rizin/meson.build:186:21: error ''gnu99,c99'' is not one of ['none', 'c89', 'c99', 'c11', 'c17', 'c18', 'c2x', 'gnu89', 'gnu99', 'gnu11', 'gnu17', 'gnu18', 'gnu2x']
186 |     capstone_proj = subproject('capstone-' + capstone_version, default_options: ['default_library=static', 'c_std=gnu99,c99'])
                          ^_________________________________________________________________________________________________________

[wargio]

Suggested change

	'c_std=gnu99',
	'c_std=gnu99,c99',

as fallback

[wargio]

Please replace all those c_std=gnu99 with c_std=gnu99,c99 for compatibility with MSVC.

[amibranch]

The libzip-1.9.2-error in windows-builds seem to be fixed upstream in dev already with 08904d2

@XVilka either rebase #3706 on current dev (and I will rebase this PR), or we continue with #4680 (and close #3706 and this PR)

[wargio]

we need to fix it in another PR, because usually we need some artifacts for a fallback repo.