Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mips update #4621

Draft
wants to merge 13 commits into
base: dev
Choose a base branch
from
Draft

Mips update #4621

wants to merge 13 commits into from

Conversation

wargio
Copy link
Member

@wargio wargio commented Sep 7, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Requires capstone-engine/capstone#2410

XVilka

This comment was marked as resolved.

Sign in to view

@XVilka XVilka requested a review from Rot127 September 25, 2024 12:30
Rot127
Rot127 reviewed Sep 26, 2024
View reviewed changes
librz/arch/p/arch_mips.c Show resolved Hide resolved
librz/arch/p/asm/asm_mips.c Outdated Show resolved Hide resolved
librz/arch/p/asm/asm_mips.c Outdated Show resolved Hide resolved
librz/core/cbin.c Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rot127 Rot127 Rot127 left review comments

@XVilka XVilka XVilka requested changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc will be requested when the pull request is marked ready for review ret2libc is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy will be requested when the pull request is marked ready for review kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r will be requested when the pull request is marked ready for review thestr4ng3r is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
API ARM ELF Mach-O MIPS rz-test RzAnalysis RzAsm-Assembler RzAsm-Disassembler RzBin RzCore RZIL RzParse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wargio @XVilka @Rot127