Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent commit keystroke being hijacked #792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

groverlynn
Copy link
Contributor

@groverlynn groverlynn commented Aug 5, 2023

By adding a placeholder before direct (panel-less) commits, keystroke hijacking is prevented. resolves #741

  • Settings: Add panelless_commit_fix: true under app_options/org.alacritty

This pull also resolves similar issues (backspace being hijacked in the address bar of chrome): resolves #435 #450 #514 etc.

  • Settings: Add inline_placeholder: true under app_options/com.google.Chrome and app_options/com.operasoftware.Opera

Furthermore, non-inline mode now works perfectly fine in terminal without even the need to have a space as placeholder (and this is the case for most apps except for a small handful e.g. chrome)

@lotem
Copy link
Member

lotem commented Feb 8, 2024

inline_offset 是新加的嗎?爲什麼 x y 用同一個值?

@lotem
Copy link
Member

lotem commented Feb 8, 2024

我準備給 Squirrel 構建成功再合併這項修改。

@groverlynn
Copy link
Contributor Author

inline_offset 是新加的嗎?爲什麼 x y 用同一個值?

Alacritty 更新一次就出一種新的bug。這次的bug就是輸入光標的位置錯位一整行,系統的capslock提示框直接覆蓋光標……想來想去只能加這麼一個選項來修正

@LEOYoon-Tsaw
Copy link
Member

#435 , #450 , #514 在最新的 Chrome (124) 已不成問題,只是爲針對 Alacritty 去「反向劫持」client,我覺得不可行,很可能導致別的 app 按鍵衝突。
除了 Alacritty 還有別的 app 需要這樣處理嗎?沒有的話就算了吧

@kola-web
Copy link

kola-web commented May 29, 2024

这个问题在neovide中也存在,我发现这种问题普遍存在与rust构建的应用程序中,但wezterm例外

@LEOYoon-Tsaw LEOYoon-Tsaw force-pushed the master branch 2 times, most recently from 4346417 to 111e615 Compare May 31, 2024 05:10
@lifei
Copy link

lifei commented Nov 11, 2024

when will this pull request be merged?

@LEOYoon-Tsaw
Copy link
Member

when will this pull request be merged?

Whenever it's ready

@lifei
Copy link

lifei commented Nov 13, 2024

when will this pull request be merged?

Whenever it's ready

when will it be ready?

@LEOYoon-Tsaw
Copy link
Member

LEOYoon-Tsaw commented Nov 13, 2024

when will this pull request be merged?

Whenever it's ready

when will it be ready?

Whom are you asking this to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants